lkml.org 
[lkml]   [2008]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] proc: return -EPERM when preventing read of /proc/*/maps
On Jan 4, 2008 4:19 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> Umm... Actually, m_next() and m_stop() both appear to be too convoluted.
>
> * m_next() never gets v == NULL
> * the only reason why we do that mmput et.al. both from ->next() and
> ->stop() is that we try to avoid having priv->mm; why bother?
> * why the _hell_ is proc_maps_private defined in include/linux/proc_fs.h,
> of all places?
> * while we are at it, why is it in any header at all? Having that sucker
> in task_mmu.c and task_nommu.c would be more than enough (and we'd avoid
> that ifdef in definition, while we are at it).
>
> How about this:

Hi Al,

Any update on this patch?
As you completely rewrote it, I thought you would take care of pushing
it forward.

Thanks.

--
Guillaume


\
 
 \ /
  Last update: 2008-02-03 19:23    [W:0.071 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site