Messages in this thread | | | From | "S.Çağlar Onur" <> | Subject | Re: trivial clean up to zlc_setup | Date | Fri, 29 Feb 2008 15:31:34 +0200 |
| |
Hi;
29 Şub 2008 Cum tarihinde, KOSAKI Motohiro şunları yazmıştı: > > > - if (jiffies - zlc->last_full_zap > 1 * HZ) { > > > + if (time_after(jiffies, zlc->last_full_zap + HZ)) { > > > bitmap_zero(zlc->fullzones, MAX_ZONES_PER_ZONELIST); > > > zlc->last_full_zap = jiffies; > > > } > > > > That's a mainline bug. Also present in 2.6.24, maybe earlier. > > But it's a minor one - we'll fix it up one second later (yes?) > > I think so, may be.
Andrew "Use time_* macros" series i sent to LKML on 14 Feb [1] has this chunk also (and by the way this version not includes linux/jiffies.h for time_after macro). Some part of this series already gone into Linus's tree with different subsystems but others not received any review/ack or nack. Will you grab others for -mm or will i resend them?
[1] http://lkml.org/lkml/2008/2/14/195
Cheers -- S.Çağlar Onur <caglar@pardus.org.tr> http://cekirdek.pardus.org.tr/~caglar/
Linux is like living in a teepee. No Windows, no Gates and an Apache in house! [unhandled content-type:application/pgp-signature] | |