lkml.org 
[lkml]   [2008]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/11] VFS: Add security label support to *notify
On Thu, Feb 28, 2008 at 03:39:30PM -0500, Dave Quigley wrote:
...
> > Alright...so, few things...
> >
> > 1) why do you need the locked/unlocked versions?
> >
> > 2) instead of passing a flag to a common function, why not have:
> >
> > vfs_setxattr_locked(....)
> > {
> > // original code minus the lock/unlock calls
> > }
> >
> > vfs_setxattr(....)
> > {
> > mutex_lock(...);
> > vfs_setxattr_locked(...);
> > mutex_unlock(...);
> > }
>
> What we do and what you propose aren't logically equivalent. There is a
> permission check inside vfs_setxattr before the mutex lock.

Ah, right. I didn't notice the @@ line...

Josef 'Jeff' Sipek.

--
Keyboard not found!
Press F1 to enter Setup


\
 
 \ /
  Last update: 2008-02-28 22:21    [W:0.055 / U:2.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site