Messages in this thread | | | Date | Wed, 27 Feb 2008 18:59:03 +0300 | From | Evgeniy Polyakov <> | Subject | Re: [2.6.25 patch] drivers/crypto/hifn_795x.c: fix 64bit division |
| |
On Tue, Feb 26, 2008 at 04:04:39PM -0800, Andrew Morton (akpm@linux-foundation.org) wrote: > udelay() might be exposed to the same problem. It would be better to fix > ndelay() and udelay() rather than callers. It is reasonable to pass a u64 > into ndelay() and to expect the build to not explode.
Well, if you think it is resonable to pass u64 into function, which is supposed to sleep no more than several cpu cycles. I do not want to start any kind of flame about it, but this looks like an overkill.
> (Geeze macros suck)
Absolutely.
-- Evgeniy Polyakov
| |