lkml.org 
[lkml]   [2008]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] CodingStyle: multiple updates
On Wed, 27 Feb 2008, Jan Engelhardt wrote:

>
> On Feb 27 2008 00:51, Krzysztof Halasa wrote:
> >Guennadi Liakhovetski <g.liakhovetski@gmx.de> writes:
> >
> >> Now, I think, I am not the only one using emacs. Until now the "linux"
> >> C-style fitted perfectly with the CodingStyle, now it no longer will.
> >> Namely, emacs puts as many tabs to indent the continuation line as fit
> >> (i.e., at tab width = 8 spaces it's just (extra indent / 8) tabs plus
> >> (extra indent % 8) spaces. Is there a way to make emacs behave compatibly
> >> to this proposal? If not, I would not like to have to re-indent every such
> >> line manually or have my patches rejected because of this.
> >
> >Oh, I'm sure nobody will reject patches because of this now. It would
> >mean no patches are accepted.
>
> Correct. Just did not want to even encourage any newcomers to use
> tabs when spacing is needed. Though, some editors unfortunately do
> just that - replacing 8 spaces by tabs on a new line when autoindent
> is on, like mcedit :-(

Then why do we define rules that we know that nobody will (be reasonably
able to) adhere to?

I can see the reasoning behind using spaces instead of tabs in
continuation lines and in in-line indentation like

int x = 1;
void *c = NULL;

or

#define X 1
#define XY 2

although I personally perfer TABs there too. But as long as we do not want
to actually impose that, I don't think we should define that.

Whereas an explicit rule requesting to use TABs and not spaces for
different indentation levels seems good.

Thanks
Guennadi
---
Guennadi Liakhovetski


\
 
 \ /
  Last update: 2008-02-27 01:19    [W:0.595 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site