lkml.org 
[lkml]   [2008]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ide-cd: fix some codestyle and most of the checkpatch.pl issues
On 2/26/08, Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
>
> On Tuesday 26 February 2008, Borislav Petkov wrote:
> > Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
> > ---
> > drivers/ide/ide-cd.c | 634
> +++++++++++++++++++++++++------------------------
> > 1 files changed, 323 insertions(+), 311 deletions(-)
>
> With 300 lines changed this is not trivial to review/apply anymore
> (yeah, I sound like a broken record ;-) and since I've already applied
> Paolo's patch from two days ago this one heavily rejects...
>
> Moreover md5sum is different before/after the patch - I tried really hard
> to figure out why (by reverting some changes) but finally I gave up.

is it because of the changes in the include section?
and was the change suggested by checkpatch.pl?

ciao,
--
Paolo
http://paolo.ciarrocchi.googlepages.com/


\
 
 \ /
  Last update: 2008-02-27 00:19    [W:0.040 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site