lkml.org 
[lkml]   [2008]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86_64: remove wrong setting about CONSTANT_TSC for intel cpu
Yinghai Lu wrote:
>> which is the same. set_cpu_cap() is indeed the cleaner form to do this
>> so your patch is correct as a cleanup.
> set_cpu_cap is right
> ==
> set_bit(X86_FEATURE_CONSTANT_TSC, &c->x86_capability); ===> is wrong
> should be
> set_bit(X86_FEATURE_CONSTANT_TSC, c->x86_capability);
>
> x86_capability is a array ...
>

For an array, the & is optional and has no effect.

So they mean the same thing.

-hpa


\
 
 \ /
  Last update: 2008-02-26 08:45    [W:0.033 / U:0.912 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site