Messages in this thread | | | Date | Tue, 26 Feb 2008 22:36:23 +0100 (CET) | From | Geert Uytterhoeven <> | Subject | Re: [Linux-fbdev-devel] [PATCH] fbcon: replace mono_col macro with static inline |
| |
On Tue, 26 Feb 2008, Harvey Harrison wrote: > On Tue, 2008-02-26 at 09:18 +0100, Geert Uytterhoeven wrote: > > On Mon, 25 Feb 2008, Harvey Harrison wrote: > > > +static inline int mono_col(struct fb_info *info) > > ^^^^^^^^^^^^^^^^^^^^ > > const struct fb_info *info? > > I suppose, but seeing as it's an inline, does it really matter?
Sure, if one day a new routine calls mono_col() passing a const struct fb_info pointer, it won't compile.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |