Messages in this thread | | | Date | Tue, 26 Feb 2008 14:37:45 +0000 | From | Ben Dooks <> | Subject | Re: [RFC] [PATCH] Fix b43 driver build for arm |
| |
On Wed, Feb 20, 2008 at 08:37:09PM +0100, Sam Ravnborg wrote: > On Wed, Feb 20, 2008 at 03:44:04PM +0100, Michael Buesch wrote: > > On Wednesday 20 February 2008 01:44:38 Gordon Farquharson wrote: > > > Hi Michael > > > > > > On Feb 19, 2008 3:41 AM, Michael Buesch <mb@bu3sch.de> wrote: > > > > > > > > [2] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=7492d4a416d68ab4bd254b36ffcc4e0138daa8ff > > > > > > > > > > > > > That doesn't cause me to magically sign off this sort of patches, too. > > > > The sanity check is clearly broken in file2alias.c, as it checks something > > > > from the target kernel against the host environment it is compiled on. > > > > That doesn't make any sense at all. > > > > > > I think that you make some good points, but I'm at a loss as to how to > > > fix the problem. Do you have any suggestions? > > > > Remove the broken sanity check, if it's not possible the check there. > The check is valid for > 99% of the kernel builds as > cross compile builds are not that typical. > And the check is there for the sake of modutils.
I build all of my ARM kernels on an x86 box, it is much faster and I don't have to ensure I have a read/write capable filesystem for any of my ARM boards.
-- Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
| |