Messages in this thread | | | Date | Mon, 25 Feb 2008 19:04:03 +0900 | From | Kohei KaiGai <> | Subject | Re: [PATCH 1/3] add a private data field within kobj_attribute structure (final#2) |
| |
Greg KH wrote: > On Mon, Feb 25, 2008 at 03:57:44PM +0900, Kohei KaiGai wrote: >> Greg KH wrote: >>> On Mon, Feb 25, 2008 at 03:10:27PM +0900, Kohei KaiGai wrote: >>>> [PATCH 1/3] add a private data field within kobj_attribute structure. >>>> >>>> This patch add a private data field, declared as void *, within >>>> kobj_attribute >>>> structure. The _show() and _store() method in the sysfs attribute entries >>>> can >>>> refer this information to identify what entry is accessed. >>>> It makes easier to share a single method implementation with several >>>> similar >>>> entries, like ones to export the list of capabilities the running kernel >>>> supports. >>>> >>>> Signed-off-by: KaiGai Kohei <kaigai@ak.jp.nec.com> >>>> -- >>>> Documentation/kobject.txt | 6 ++++++ >>> That's good, but you didn't modify the sample/kobject/ file to use the >>> new void pointer, instead of the strcmp() call. >> The 3/3 of patches updates sample/kobject to use the new void pointer. >> Do you want it to replace strcmp() examples completly? > > Doh, I totally missed that one, very sorry. I'll be glad to take > patches 1 and 3 in my tree, if you want me to.
I want them to be upstreamed, no need to say.
BTW, how do you think about the second patch which provides the most practical feature?
Thanks for your reviewing. -- OSS Platform Development Division, NEC KaiGai Kohei <kaigai@ak.jp.nec.com>
| |