Messages in this thread | | | Date | Sun, 24 Feb 2008 19:14:13 +0100 | From | "Paolo Ciarrocchi" <> | Subject | Re: [PATCH] Change a WARN message in checkpatch |
| |
On Sun, Feb 24, 2008 at 4:18 PM, Benny Halevy <bhalevy@panasas.com> wrote: [...] > How about: > - WARN("no space between function name and open parenthesis '('\n" . $herecurr); > + WARN("there should be no space between function name and open parenthesis '('\n" . $herecurr);
I originally suggested: + WARN("don't put a space between function name and open parenthesis '('\n" . $herecurr); but I really prefer your version.
> The original phrasing can be interpreted like "there is no space between ..." and the correct > interpretation should be "there should be no space between ..."
Indeed.
Ciao, -- Paolo http://paolo.ciarrocchi.googlepages.com/
| |