Messages in this thread Patch in this message | | | Date | Sat, 23 Feb 2008 14:47:29 -0800 | From | menage@google ... | Subject | [PATCH 04/10] CGroup API files: Strip all trailing whitespace in cgroup_write_u64 |
| |
This removes the need for people to remember to pass the -n flag to echo when writing values to cgroup control files.
Signed-off-by: Paul Menage <menage@google.com>
--- kernel/cgroup.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
Index: cgroup-2.6.25-rc2-mm1/kernel/cgroup.c =================================================================== --- cgroup-2.6.25-rc2-mm1.orig/kernel/cgroup.c +++ cgroup-2.6.25-rc2-mm1/kernel/cgroup.c @@ -1321,10 +1321,7 @@ static ssize_t cgroup_write_u64(struct c return -EFAULT; buffer[nbytes] = 0; /* nul-terminate */ - - /* strip newline if necessary */ - if (nbytes && (buffer[nbytes-1] == '\n')) - buffer[nbytes-1] = 0; + strstrip(buffer); val = simple_strtoull(buffer, &end, 0); if (*end) return -EINVAL; --
| |