Messages in this thread | | | Date | Sat, 23 Feb 2008 16:18:41 +0200 | From | Adrian Bunk <> | Subject | Re: [PATCH 08/10] IDE: Coding Style fixes to drivers/ide/pci/generic.c |
| |
On Sat, Feb 23, 2008 at 03:05:47PM +0100, Paolo Ciarrocchi wrote: > File is now error free. > Compile tested. > > > Signed-off-by: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com> > --- > drivers/ide/pci/generic.c | 50 ++++++++++++++++++++++---------------------- > 1 files changed, 25 insertions(+), 25 deletions(-) > > diff --git a/drivers/ide/pci/generic.c b/drivers/ide/pci/generic.c > index f83afa1..f9a5879 100644 > --- a/drivers/ide/pci/generic.c > +++ b/drivers/ide/pci/generic.c >... > - /* 2 */ DECLARE_GENERIC_PCI_DEV("SAMURAI", 0), > - /* 3 */ DECLARE_GENERIC_PCI_DEV("HT6565", 0), > - /* 4 */ DECLARE_GENERIC_PCI_DEV("UM8673F", IDE_HFLAGS_UMC), > - /* 5 */ DECLARE_GENERIC_PCI_DEV("UM8886A", IDE_HFLAGS_UMC), > - /* 6 */ DECLARE_GENERIC_PCI_DEV("UM8886BF", IDE_HFLAGS_UMC), > - /* 7 */ DECLARE_GENERIC_PCI_DEV("HINT_IDE", 0), > - /* 8 */ DECLARE_GENERIC_PCI_DEV("VIA_IDE", IDE_HFLAG_NO_AUTODMA), > - /* 9 */ DECLARE_GENERIC_PCI_DEV("OPTI621V", IDE_HFLAG_NO_AUTODMA), > + /* 2 */ DECLARE_GENERIC_PCI_DEV("SAMURAI", 0), > + /* 3 */ DECLARE_GENERIC_PCI_DEV("HT6565", 0), > + /* 4 */ DECLARE_GENERIC_PCI_DEV("UM8673F", IDE_HFLAGS_UMC), > + /* 5 */ DECLARE_GENERIC_PCI_DEV("UM8886A", IDE_HFLAGS_UMC), > + /* 6 */ DECLARE_GENERIC_PCI_DEV("UM8886BF", IDE_HFLAGS_UMC), > + /* 7 */ DECLARE_GENERIC_PCI_DEV("HINT_IDE", 0), > + /* 8 */ DECLARE_GENERIC_PCI_DEV("VIA_IDE", IDE_HFLAG_NO_AUTODMA), > + /* 9 */ DECLARE_GENERIC_PCI_DEV("OPTI621V", IDE_HFLAG_NO_AUTODMA), >...
I do not even see checkpatch complaining about this, and even if it did your patch would make the code _less_ readable.
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
| |