| Subject | Re: [RFC PATCH 0/8]: uninline & uninline | From | Andi Kleen <> | Date | Sat, 23 Feb 2008 14:15:06 +0100 |
| |
Andrew Morton <akpm@linux-foundation.org> writes:
>> -41525 2066 f, 3370 +, 44895 -, diff: -41525 IS_ERR > > This is a surprise. I expect that the -mm-only > profile-likely-unlikely-macros.patch is the cause of this and mainline > doesn't have this problem.
Shouldn't they only have overhead when the respective CONFIG is enabled?
> If true, then this likely/unlikely bloat has probably spread into a lot of > your other results and it all should be redone against mainline, sorry :( > > (I'm not aware of anyone having used profile-likely-unlikely-macros.patch > in quite some time. That's unfortunate because it has turned up some > fairly flagrant code deoptimisations)
Is there any reason they couldn't just be merged to mainline?
I think it's a useful facility.
-Andi
|