Messages in this thread | | | Date | Sat, 23 Feb 2008 11:25:39 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86: don't save unreliable stack trace entries |
| |
* Arjan van de Ven <arjan@infradead.org> wrote:
> > b/arch/x86/kernel/stacktrace.c index 02f0f61..c28c342 100644 > > --- a/arch/x86/kernel/stacktrace.c > > +++ b/arch/x86/kernel/stacktrace.c > > @@ -25,6 +25,8 @@ static int save_stack_stack(void *data, char *name) > > static void save_stack_address(void *data, unsigned long addr, int > > reliable) { > > struct stack_trace *trace = data; > > + if (!reliable) > > + return; > > if (trace->skip > 0) { > > trace->skip--; > > return; > > @@ -37,6 +39,8 @@ static void > > save_stack_address_nosched(void *data, unsigned long addr, int > > reliable) { > > struct stack_trace *trace = (struct stack_trace *)data; > > + if (!reliable) > > + return; > > if (in_sched_functions(addr)) > > return; > > if (trace->skip > 0) { > > > I was about to make a patch for this second chunk myself and submit > it, so for the second chunk a strong: > Acked-by: Arjan van de Ven <arjan@linux.intel.com>
how about the first chunk?
Ingo
| |