lkml.org 
[lkml]   [2008]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 20/20] x86: Coding Style fixes to arch/x86/xen/multicalls.c

* Joe Perches <joe@perches.com> wrote:

> > printk(KERN_ERR "%d multicall(s) failed: cpu %d\n",
> > ret, smp_processor_id());
> > - for(i = 0; i < b->mcidx; i++) {
> > + for (i = 0; i < b->mcidx; i++) {
> > printk(" call %2d/%d: op=%lu arg=[%lx] result=%ld\n",
>
> The printk needs a KERN_ERR prefix

yes - but we prefer to isolate the "does not change the .o in any way"
cleanups from cleanups that materially change kernel behavior. (such as
printing something else)

Ingo


\
 
 \ /
  Last update: 2008-02-23 11:05    [W:0.033 / U:0.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site