lkml.org 
[lkml]   [2008]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 33/38] SCSI: gdth: scan for scsi devices
On Sat, Feb 23, 2008 at 2:31 AM, Greg KH <gregkh@suse.de> wrote:
>
> 2.6.24-stable review patch. If anyone has any objections, please let us
> know.
>
> ------------------
> From: Boaz Harrosh <bharrosh@panasas.com>
>
> commit: 61c92814dc324b541391757062ff02fbf3b08086
>
> The patch: "gdth: switch to modern scsi host registration"
>
> missed one simple fact when moving a way from scsi_module.c.
> That is to call scsi_scan_host() on the probed host.
> With this the gdth driver from 2.6.24 is again able to
> see drives and boot.
>
> Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
> Tested-by: Joerg Dorchain <joerg@dorchain.net>
> Tested-by: Stefan Priebe <s.priebe@allied-internet.ag>
> Tested-by: Jon Chelton <jchelton@ffpglobal.com>
> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
>
> ---
> drivers/scsi/gdth.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> --- a/drivers/scsi/gdth.c
> +++ b/drivers/scsi/gdth.c
> @@ -4838,6 +4838,9 @@ static int __init gdth_isa_probe_one(ulo
> if (error)
> goto out_free_coal_stat;
> list_add_tail(&ha->list, &gdth_instances);
> +
> + scsi_scan_host(shp);
> +
> return 0;
>
> out_free_coal_stat:
> @@ -4965,6 +4968,9 @@ static int __init gdth_eisa_probe_one(us
> if (error)
> goto out_free_coal_stat;
> list_add_tail(&ha->list, &gdth_instances);
> +
> + scsi_scan_host(shp);
> +
> return 0;
>
> out_free_ccb_phys:
> @@ -5102,6 +5108,9 @@ static int __init gdth_pci_probe_one(gdt
> if (error)
> goto out_free_coal_stat;
> list_add_tail(&ha->list, &gdth_instances);
> +
> + scsi_scan_host(shp);
> +
> return 0;
>
> out_free_coal_stat:
>
> --

Greg, James Hi

This patch is not enough, and will not return a gdth system to working
order. With this patch disks
will show up again, only to crash later. All the 5 patches I sent are
needed, to return to a working
state. James please apply to mainline, so they can be accepted into stable.
of the 5 only 2 I have seen in mainline. 3 are missing.
(if they were submitted, I might have missed them, as I'm traveling, then sorry)

Boaz


\
 
 \ /
  Last update: 2008-02-23 04:05    [W:0.199 / U:0.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site