Messages in this thread | | | Date | Fri, 22 Feb 2008 18:02:06 -0600 | From | "Serge E. Hallyn" <> | Subject | Re: [2.6 patch] kernel/ns_cgroup.c should #include <linux/nsproxy.h> |
| |
Quoting Adrian Bunk (bunk@kernel.org): > Every file should include the headers containing the externs its global > functions (in this case for ns_cgroup_clone()). > > Signed-off-by: Adrian Bunk <bunk@kernel.org>
Seems fine... and a good way to ensure that the prototype and definition match.
Acked-by: Serge Hallyn <serue@us.ibm.com>
thanks, -serge
> > --- > d3446a02068091d59425c51bde1daea777398e44 diff --git a/kernel/ns_cgroup.c b/kernel/ns_cgroup.c > index aead4d6..659f321 100644 > --- a/kernel/ns_cgroup.c > +++ b/kernel/ns_cgroup.c > @@ -7,6 +7,7 @@ > #include <linux/module.h> > #include <linux/cgroup.h> > #include <linux/fs.h> > +#include <linux/nsproxy.h> > > struct ns_cgroup { > struct cgroup_subsys_state css;
| |