lkml.org 
[lkml]   [2008]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6 patch] kernel/ns_cgroup.c should #include <linux/nsproxy.h>
Quoting Adrian Bunk (bunk@kernel.org):
> Every file should include the headers containing the externs its global
> functions (in this case for ns_cgroup_clone()).
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>

Seems fine... and a good way to ensure that the prototype and
definition match.

Acked-by: Serge Hallyn <serue@us.ibm.com>

thanks,
-serge

>
> ---
> d3446a02068091d59425c51bde1daea777398e44 diff --git a/kernel/ns_cgroup.c b/kernel/ns_cgroup.c
> index aead4d6..659f321 100644
> --- a/kernel/ns_cgroup.c
> +++ b/kernel/ns_cgroup.c
> @@ -7,6 +7,7 @@
> #include <linux/module.h>
> #include <linux/cgroup.h>
> #include <linux/fs.h>
> +#include <linux/nsproxy.h>
>
> struct ns_cgroup {
> struct cgroup_subsys_state css;


\
 
 \ /
  Last update: 2008-02-23 01:05    [W:0.182 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site