Messages in this thread | | | Date | Thu, 21 Feb 2008 07:04:27 +0100 | From | Ingo Molnar <> | Subject | Re: Make yield_task_fair more efficient |
| |
* Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> __pick_last_entity() walks the entire tree on O(lgn) time to find the > rightmost entry. This patch makes the routine more efficient by > reducing the cost of the lookup
hm, i'm not sure we want to do this: we'd be slowing down the fastpath of all the other common scheduler functions, for the sake of a rarely used (and broken ...) API: yield. And note that an rbtree walk is not slow at all - if you are yielding frequently it's probably all cached.
Ingo
| |