Messages in this thread | | | Subject | RE: [git patches] net driver updates | From | Krishna Kumar2 <> | Date | Thu, 21 Feb 2008 11:32:08 +0530 |
| |
Hi Divy,
But the race doesn't exist even for LLTX drivers these days. There is no way two cpu's can execute the xmit handler at the same time.
Thanks,
- KK
> > > > The first part of the patch removes the !netif_queue_stopped(dev). > > > > It opens the race discussed a while ago between Stephen hemminger > > and > > > > David Miller: > > > > http://marc.info/?l=linux-netdev&m=113383224512427&w=2 > > > > > > I feel this race cannot happen anymore. I think the fix for that > race > > was > > > to introduce the > > > __LINK_STATE_QDISC_RUNNING bit thus eliminating any races between > > CPU's. If > > > one > > > CPU has called xmit, the other CPU will enqueue skbs (by holding the > > > queue_lock) and > > > exit from qdisc_run since it finds the bit set already. > > > > And the race is talking about LLTX, which S2IO doesn't use as > > far as I can tell. > > Dave, > > The driver is cxgb3 here, it uses LLTX. > > Cheers, > Divy
| |