lkml.org 
[lkml]   [2008]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] x86 : relocate uninitialized variable in init DATA section into init BSS section

* Huang, Ying <ying.huang@intel.com> wrote:

> > > -int __initdata early_ioremap_debug;
> > > +int __initbss early_ioremap_debug;
> >
> > will we get some sort of build error if we accidentally do:
> >
> > int __initbss early_ioremap_debug = 1;
> >
> > ?
>
> I tested it just now, and there is no build error.

well, that's bad. We'd silently ignore the " = 1" and boot up with that
value at 0, right? At minimum we need some really prominent build-time
_errors_ (i.e. aborted builds) if this ever happens. But ideally,
shouldnt this whole thing be done at link time? Couldnt the linker sort
the variables that are zero initialized into the right section, and move
this constant maintenance pressure off the programmer's shoulder?

Ingo


\
 
 \ /
  Last update: 2008-02-21 10:57    [W:0.079 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site