Messages in this thread | | | Date | Fri, 22 Feb 2008 01:58:17 +0300 | Subject | Re: Merging of completely unreviewed drivers | From | Alexey Dobriyan <> |
| |
On Thu, Feb 21, 2008 at 02:43:15PM -0800, Greg KH wrote: > On Fri, Feb 22, 2008 at 01:33:03AM +0300, Alexey Dobriyan wrote: > > On Thu, Feb 21, 2008 at 01:14:55PM -0800, Linus Torvalds wrote: > > > Quite frankly, I've several times been *this* close (holds up fingers so > > > you can't even see between them) to just remove checkpatch entirely. > > > > Agrh! What stopped you?! > > > > > I'm personally of the opinion that a lot of checkpatch "fixes" are > > > anything but. That mainly concerns fixing overlong lines (where the > > > "fixed" version is usually worse than the original), but it's been true > > > for some other warnings too. > > > > Speaking of driver, could authors please comment all those barrier() > > calls and remove trailing "return;" at the end of void functions. > > Why don't you make a patch to checkpatch.pl for those types of things? > :)
Sorry, I'm not touching it with an eigthy six foot pole. :^)
| |