Messages in this thread | | | Date | Thu, 21 Feb 2008 13:33:45 -0800 | From | Greg KH <> | Subject | Re: [PATCH] 2.4: Back-port of pl2303.c from 2.6.24.1 |
| |
On Thu, Feb 21, 2008 at 10:00:58PM +0100, Willy Tarreau wrote: > Hi Greg, Hi David, > > On Thu, Feb 21, 2008 at 12:36:40PM -0800, Greg KH wrote: > > On Fri, Feb 22, 2008 at 06:51:34AM +1030, David Newall wrote: > > > Hi Willy, > > > > > > Lacking hardware for a week, I've had a bit of a hiatus from PL2303, but > > > I've got it back again now, and finished my work back-porting the 2.6 > > > driver to 2.4. Here's a new patch, which is more complete than my > > > previous one. It's based on the 2.6.24.1. > > > > > > There's a lot of trivial white-space changes and some things that have > > > been moved, which make the patch rather larger than it could be. I > > > didn't include those changes before, but have now in order that the > > > driver be closer to the 2.6 driver. It'll never be identical, of course. > > > > > > Note, too, that the 2.6 driver (and thus the patched 2.4) includes a 1k > > > circular buffer which rather duplicates a buffer in the 2.4 usbserial.c; > > > 2.6's usb-serial has had that buffer removed. As the buffer resolves > > > loss of the occasional putchar (e.g. from n_tty's opost), it is > > > important and correct, even in 2.4. > > > > > > Speaking as a user, I no longer see any problems with PL2303, and I > > > think this is okay to release. > > > > If this works for you, I have no objection to it, but I can't test it as > > I don't run 2.4 on anything anymore :) > > I too agree to merge, it especially since it fixed several problems > for David. However, I would like to know first if the same problems > also happen with the 2.6 driver or if it is OK. The risk is getting > 2.4 fixed and not 2.6, which could cause regressions for people upgrading > from 2.4 to 2.6. Of course, a regression on a USB-serial adapter is > not dramatic, but it's a general principle to keep in mind that 2.6 > should be safe (or at least actively being fixed) when merging driver > changes in 2.4.
As far as I can tell, this was a backport of the current 2.6 driver, so it should not have fixes that are not already in 2.6.
David, is that true?
thanks,
greg k-h
| |