lkml.org 
[lkml]   [2008]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] X86: don't print a warning when MTRR are blank and running in KVM

* Joerg Roedel <joerg.roedel@amd.com> wrote:

> - if (!highest_pfn) {
> + if (!highest_pfn && !kvm_para_available()) {
> printk(KERN_WARNING "WARNING: strange, CPU MTRRs all blank?\n");
> WARN_ON(1);
> - return 0;
> }
>
> + if (!highest_pfn)
> + return 0;

hm, why not have a single test for !highest_pfn:

if (!highest_pfn) {
if (!kvm_para_available()) {
printk(KERN_WARNING
"WARNING: strange, CPU MTRRs all blank?\n");
WARN_ON(1);
}
return 0;
}

? But yeah, your patch looks good otherwise.

I'm not sure how we could detect pure Qemu instances - perhaps it should
define some special MSR or something?

Ingo


\
 
 \ /
  Last update: 2008-02-21 21:41    [W:0.046 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site