lkml.org 
[lkml]   [2008]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 00/37] Permit filesystem local caching
Date
Serge E. Hallyn <serue@us.ibm.com> wrote:

> Seems *really* weird that every time you send this, patch 6 doesn't seem
> to reach me in any of my mailboxes... (did get it from the url
> you listed)

It's the largest of the patches, so that's not entirely surprising. Hence why
I included the URL to the tarball also.

> I'm sorry if I miss where you explicitly state this, but is it safe to
> assume, as perusing the patches suggests, that
>
> 1. tsk->sec never changes other than in task_alloc_security()?

Correct.

> 2. tsk->act_as is only ever dereferenced from (a) current->

That ought to be correct.

> except (b) in do_coredump?

Actually, do_coredump() only deals with current->act_as.

> (thereby carefully avoiding locking issues)

That's the idea.

> I'd still like to see some performance numbers. Not to object to
> these patches, just to make sure there's no need to try and optimize
> more of the dereferences away when they're not needed.

I hope that the performance impact is minimal. The kernel should spend very
little time looking at the security data. I'll try and get some though.

> Oh, manually copied from patch 6, I see you have in the task_security
> struct definition:
>
> kernel_cap_t cap_bset; /* ? */
>
> That comment can be filled in with 'capability bounding set' (for this
> task and all its future descendents).

Thanks.

David


\
 
 \ /
  Last update: 2008-02-20 21:25    [W:0.255 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site