Messages in this thread | | | Date | Tue, 19 Feb 2008 19:01:44 -0800 | From | "Paul Menage" <> | Subject | Re: [PATCH 2/7] cgroup: fix comments |
| |
On Feb 17, 2008 9:49 PM, Li Zefan <lizf@cn.fujitsu.com> wrote: > fix: > - comments about need_forkexit_callback > - comments about release agent > - typo and comment style, etc. > > Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> > --- > include/linux/cgroup.h | 2 +- > kernel/cgroup.c | 44 +++++++++++++++++++++----------------------- > 2 files changed, 22 insertions(+), 24 deletions(-) > > diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h > index ff9055f..2ebf7af 100644 > --- a/include/linux/cgroup.h > +++ b/include/linux/cgroup.h > @@ -175,7 +175,7 @@ struct css_set { > * > * > * When reading/writing to a file: > - * - the cgroup to use in file->f_dentry->d_parent->d_fsdata > + * - the cgroup to use is file->f_dentry->d_parent->d_fsdata > * - the 'cftype' of the file is file->f_dentry->d_fsdata > */ > > diff --git a/kernel/cgroup.c b/kernel/cgroup.c > index 4766bb6..0c35022 100644 > --- a/kernel/cgroup.c > +++ b/kernel/cgroup.c > @@ -113,9 +113,9 @@ static int root_count; > #define dummytop (&rootnode.top_cgroup) > > /* This flag indicates whether tasks in the fork and exit paths should > - * take callback_mutex and check for fork/exit handlers to call. This > - * avoids us having to do extra work in the fork/exit path if none of the > - * subsystems need to be called. > + * check for fork/exit handlers to call. This avoids us having to do > + * extra work in the fork/exit path if none of the subsystems need to > + * be called. > */ > static int need_forkexit_callback; > > @@ -507,8 +507,8 @@ static struct css_set *find_css_set( > * critical pieces of code here. The exception occurs on cgroup_exit(), > * when a task in a notify_on_release cgroup exits. Then cgroup_mutex > * is taken, and if the cgroup count is zero, a usermode call made > - * to /sbin/cgroup_release_agent with the name of the cgroup (path > - * relative to the root of cgroup file system) as the argument. > + * to the release agent with the name of the cgroup (path relative to > + * the root of cgroup file system) as the argument. > * > * A cgroup can only be deleted if both its 'count' of using tasks > * is zero, and its list of 'children' cgroups is empty. Since all > @@ -521,7 +521,7 @@ static struct css_set *find_css_set( > * > * The need for this exception arises from the action of > * cgroup_attach_task(), which overwrites one tasks cgroup pointer with > - * another. It does so using cgroup_mutexe, however there are > + * another. It does so using cgroup_mutex, however there are > * several performance critical places that need to reference > * task->cgroup without the expense of grabbing a system global > * mutex. Therefore except as noted below, when dereferencing or, as > @@ -1192,7 +1192,7 @@ static void get_first_subsys(const struct cgroup *cgrp, > * Attach task 'tsk' to cgroup 'cgrp' > * > * Call holding cgroup_mutex. May take task_lock of > - * the task 'pid' during call. > + * the task 'tsk' during call. > */ > int cgroup_attach_task(struct cgroup *cgrp, struct task_struct *tsk) > { > @@ -1584,12 +1584,11 @@ static int cgroup_create_file(struct dentry *dentry, int mode, > } > > /*
I think that docbook-style function comments need /** at the start of the comment block.
Thanks,
Paul
| |