Messages in this thread | | | Date | Wed, 20 Feb 2008 08:27:56 +0900 | From | Mattia Dongili <> | Subject | Re: [2.6 patch] sony-laptop.c: fix off-by-one |
| |
On Wed, Feb 20, 2008 at 12:59:03AM +0200, Adrian Bunk wrote: > This patch fixes an off-by-one spotted by the Coverity checker. > > Signed-off-by: Adrian Bunk <bunk@kernel.org>
Acked-by: Mattia Dongili <malattia@linux.it>
> --- > --- linux-2.6/drivers/misc/sony-laptop.c.old 2008-02-20 00:26:21.000000000 +0200 > +++ linux-2.6/drivers/misc/sony-laptop.c 2008-02-20 00:26:38.000000000 +0200 > @@ -314,9 +314,9 @@ static void sony_laptop_report_input_eve > kp.dev = jog_dev; > break; > > default: > - if (event > ARRAY_SIZE(sony_laptop_input_index)) { > + if (event >= ARRAY_SIZE(sony_laptop_input_index)) { > dprintk("sony_laptop_report_input_event, event not known: %d\n", event); > break; > } > if (sony_laptop_input_index[event] != -1) { > > - > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- mattia :wq!
| |