Messages in this thread | | | Date | Mon, 18 Feb 2008 04:50:20 -0500 (EST) | From | "Robert P. J. Day" <> | Subject | Re: [PATCH] linux/hdsmart.h: fix goofups |
| |
On Mon, 18 Feb 2008, Valdis.Kletnieks@vt.edu wrote:
> On Sun, 17 Feb 2008 12:17:20 EST, "Robert P. J. Day" said: > > > if that header file isn't used by any kernel code, why bother having a > > check for __KERNEL__ in the first place? it's being exported to > > userspace unchecked: > > > > include/linux/Kbuild:header-y += hdsmart.h > > > > so why not just toss that check entirely? otherwise, you're going to > > get a header file exported to userspace that has a superfluous > > __KERNEL__ test in it. > > Umm... if the kernel isn't using it, why are we bothering to export > it to userspace at all? Or is the kernel using something *else* > that should be going to userspace instead?
beats me, i just observe 'em, i don't make those judgment calls. :-)
rday --
======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry: Have classroom, will lecture.
http://crashcourse.ca Waterloo, Ontario, CANADA ========================================================================
| |