lkml.org 
[lkml]   [2008]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] linux/hdsmart.h: fix goofups
On Mon, 18 Feb 2008, Valdis.Kletnieks@vt.edu wrote:

> On Sun, 17 Feb 2008 12:17:20 EST, "Robert P. J. Day" said:
>
> > if that header file isn't used by any kernel code, why bother having a
> > check for __KERNEL__ in the first place? it's being exported to
> > userspace unchecked:
> >
> > include/linux/Kbuild:header-y += hdsmart.h
> >
> > so why not just toss that check entirely? otherwise, you're going to
> > get a header file exported to userspace that has a superfluous
> > __KERNEL__ test in it.
>
> Umm... if the kernel isn't using it, why are we bothering to export
> it to userspace at all? Or is the kernel using something *else*
> that should be going to userspace instead?

beats me, i just observe 'em, i don't make those judgment calls. :-)

rday
--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.

http://crashcourse.ca Waterloo, Ontario, CANADA
========================================================================


\
 
 \ /
  Last update: 2008-02-18 10:53    [W:0.215 / U:0.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site