Messages in this thread | | | Date | Mon, 18 Feb 2008 12:14:53 -0800 | From | Mark Fasheh <> | Subject | Re: [PATCH 3/7] fs/ocfs2: Use BUG_ON |
| |
On Sun, Feb 17, 2008 at 06:55:49PM +0100, Julia Lawall wrote: > From: Julia Lawall <julia@diku.dk> > > if (...) BUG(); should be replaced with BUG_ON(...) when the test has no > side-effects to allow a definition of BUG_ON that drops the code completely. > > The semantic patch that makes this change is as follows: > (http://www.emn.fr/x-info/coccinelle/) > > // <smpl> > @ disable unlikely @ expression E,f; @@ > > ( > if (<... f(...) ...>) { BUG(); } > | > - if (unlikely(E)) { BUG(); } > + BUG_ON(E); > ) > > @@ expression E,f; @@ > > ( > if (<... f(...) ...>) { BUG(); } > | > - if (E) { BUG(); } > + BUG_ON(E); > ) > // </smpl> > > Signed-off-by: Julia Lawall <julia@diku.dk> Acked-by: Mark Fasheh <mark.fasheh@oracle.com>
-- Mark Fasheh Principal Software Developer, Oracle mark.fasheh@oracle.com
| |