lkml.org 
[lkml]   [2008]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -mmotm] fs/sysfs/file.c d_path fix
On Sun, Feb 17, Christoph Hellwig wrote:

> On Sat, Feb 16, 2008 at 02:12:05PM -0500, Erez Zadok wrote:
> > diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c
> > index 02223e2..a57b024 100644
> > --- a/fs/sysfs/file.c
> > +++ b/fs/sysfs/file.c
> > @@ -329,9 +329,11 @@ static int sysfs_open_file(struct inode *inode, struct file *file)
> > struct sysfs_ops *ops;
> > int error = -EACCES;
> > char *p;
> > + struct path sysfs_path;
> >
> > - p = d_path(file->f_dentry, sysfs_mount, last_sysfs_file,
> > - sizeof(last_sysfs_file));
> > + sysfs_path.dentry = file->f_dentry;
> > + sysfs_path.mnt = sysfs_mount;
> > + p = d_path(&sysfs_path, last_sysfs_file, sizeof(last_sysfs_file));
>
> A d_path(file->f_path, ..); should do it, but I'd really like to know
> what sysfs crowd was smoking when adding a d_path in ->open. Guys,
> please explain what's going on here.
>

This is from gregkh-driver-sysfs-crash-debugging.patch which is only in -mm I
guess.


\
 
 \ /
  Last update: 2008-02-18 17:47    [W:1.926 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site