Messages in this thread | | | Date | Sun, 17 Feb 2008 16:10:09 +0000 | From | Iain Paton <> | Subject | Re: Geode GX/LX watchdog timer (RESEND) |
| |
Adrian Bunk wrote: > On Sun, Feb 17, 2008 at 03:46:01PM +0100, Arnd Hannemann wrote: >> Never tried to built it as a module. >> Probably there are issues with that. If I remember correctly I saw a patch in 2.6.25-rc which >> mentioned that using mfgpt in modules won't work. Does this apply to 2.6.24 as well? > > For using code from modules it must be explicitely EXPORT_SYMBOL{,GPL}'ed. > > Adding > EXPORT_SYMBOL_GPL(geode_mfgpt_toggle_event); > and > EXPORT_SYMBOL_GPL(geode_mfgpt_alloc_timer); > below the respective functions in mfgpt_32.c should fix this issue.
I couldn't find the patch Arnd mentioned on lkml or in Linus git tree, but adding the lines suggested by Adrian gets me a working module.
Hopefully the patch will arrive in the mainline tree at some point.
Thanks to both of you for the help!
Iain
| |