lkml.org 
[lkml]   [2008]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: 2.6.25-rc2-mm1 (wakeup)
On Sat, 16 Feb 2008 17:22:52 -0800 H. Peter Anvin wrote:

> Rafael J. Wysocki wrote:
> > On Saturday, 16 of February 2008, Randy Dunlap wrote:
> >> On Sat, 16 Feb 2008 00:25:22 -0800 Andrew Morton wrote:
> >>
> >>> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.25-rc2/2.6.25-rc2-mm1/
> >> The ACPI wakeup in C patch (I think) won't build for me on x86_32
> >> (i.e., i386 build on x86_64 system):
> >>
> >> linux-2.6.25-rc2-mm1/arch/x86/kernel/acpi/realmode/wakeup.S:0: error: CPU you selected does not support x86-64 instruction set
> >> linux-2.6.25-rc2-mm1/arch/x86/kernel/acpi/realmode/wakeup.S:0: error: CPU you selected does not support x86-64 instruction set
> >> linux-2.6.25-rc2-mm1/arch/x86/kernel/acpi/realmode/wakeup.S:0: error: -mpreferred-stack-boundary=2 is not between 4 and 12
> >> make[4]: *** [arch/x86/kernel/acpi/realmode/wakeup.o] Error 1
> >> make[3]: *** [arch/x86/kernel/acpi/realmode/wakeup.bin] Error 2
> >
> > It compiles for me on a native i386.
> >
> > Can you please give me a hint what to do to reproduce the problem?
>
> Sounds like you're not adding -m32 to the gcc command line.

Yes, adding -m32 to the X86_32 config ccflags (as is done for the
X86_64 case) makes it build for me. (like patch below)

Thanks.
---

From: Randy Dunlap <randy.dunlap@oracle.com>

Fix wakeup code build errors on x86_64.

linux-2.6.25-rc2-mm1/arch/x86/kernel/acpi/realmode/wakeup.S:0: error: CPU you selected does not support x86-64 instruction set
linux-2.6.25-rc2-mm1/arch/x86/kernel/acpi/realmode/wakeup.S:0: error: CPU you selected does not support x86-64 instruction set
linux-2.6.25-rc2-mm1/arch/x86/kernel/acpi/realmode/wakeup.S:0: error: -mpreferred-stack-boundary=2 is not between 4 and 12

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
arch/x86/kernel/acpi/realmode/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.25-rc2-mm1.orig/arch/x86/kernel/acpi/realmode/Makefile
+++ linux-2.6.25-rc2-mm1/arch/x86/kernel/acpi/realmode/Makefile
@@ -27,7 +27,7 @@ bootsrc := $(src)/../../../boot
# How to compile the 16-bit code. Note we always compile for -march=i386,
# that way we can complain to the user if the CPU is insufficient.
# Compile with _SETUP since this is similar to the boot-time setup code.
-cflags-$(CONFIG_X86_32) :=
+cflags-$(CONFIG_X86_32) := -m32
cflags-$(CONFIG_X86_64) := -m32
KBUILD_CFLAGS := $(LINUXINCLUDE) -g -Os -D_SETUP -D_WAKEUP -D__KERNEL__ \
-I$(srctree)/$(bootsrc) \

\
 
 \ /
  Last update: 2008-02-17 03:23    [W:0.144 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site