lkml.org 
[lkml]   [2008]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch] fuse: fix permission checking
From
Date
On Fri, 2008-02-15 at 11:23 +0100, Miklos Szeredi wrote:
> This is for 2.6.25 and 2.6.24.y, but NOT for 2.6.23.y.
>
> Thanks,
> Miklos
> ----
>
> From: Miklos Szeredi <mszeredi@suse.cz>
>
> I added a nasty local variable shadowing bug to fuse in 2.6.24, with
> the result, that the 'default_permissions' mount option is basically
> ignored.
>
> How did this happen?
>
> - old err declaration in inner scope
> - new err getting declared in outer scope
> - 'return err' from inner scope getting removed
> - old declaration not being noticed
>
> -Wshadow would have saved us, but it doesn't seem practical for
> the kernel :(
>
> More testing would have also saved us :((

sparse would have saved you too.

Harvey



\
 
 \ /
  Last update: 2008-02-15 21:39    [W:0.113 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site