Messages in this thread | | | Date | Wed, 13 Feb 2008 10:57:37 +0200 | From | Boaz Harrosh <> | Subject | Re: [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device |
| |
On Wed, Feb 13 2008 at 2:17 +0200, James Bottomley <James.Bottomley@HansenPartnership.com> wrote: > On Tue, 2008-02-12 at 20:48 -0300, Sergio Luis wrote: >> reposting an updated version of it. Please check if it's ok. > > Looks fine, thanks! You added an extra space at the end of > > while ((pdev = pci_get_device(vendor, device, pdev)) > > Which I fixed. Unfortunately checkpatch isn't very helpful for this > driver since it uses spaces not tabs everywhere, which checkpatch really > hates. > > James > > James hi This patch is now obsolete. After Jeff's patch to convert it to hot plug API. Jeffs patch looks very good to me. I will try to push it through the testers.
I still don't have a card for testing myself. Again anyone wants to send me a card. Intel people anybody home?
I will add the missing Kconfig hunk to jeff's patch and will push it after it is tested.
Thanks Boaz
| |