Messages in this thread | | | Date | Mon, 11 Feb 2008 16:56:11 -0800 | From | "H. Peter Anvin" <> | Subject | Re: REPOST: [PATCH] Add iSCSI iBFT support (v0.4.7) |
| |
Greg KH wrote: > On Mon, Feb 11, 2008 at 06:35:16PM -0500, Konrad Rzeszutek wrote: >>>> + if (hdr->id == id_nic) { >>>> + pci_dev = pci_get_bus_and_slot((nic->pci_bdf & 0xff00) >> >>>> 8, + (nic->pci_bdf & 0xff)); >>> pci_get_bus_and_slot fails in the presence of PCI domains, which are >>> getting to be fairly common even in medium sized servers ... what >>> happens in that case? >> The specification did not take that in to account. The Bus/Dev/Func >> information is only present there - no domain information. > > That's really broken then. Common i386 boxes these days have multiple > PCI domains, it's not all that uncommon at all. > > And almost all big 64 bit boxes have them.
Yes, but common x86 boxes can't *boot* from anything but domain 0 (in particular, the domain which the cf8/cfc registers on the boot processor activate.)
-hpa
| |