Messages in this thread | | | Date | Mon, 11 Feb 2008 14:59:47 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] x86 (Linux Tiny): configure out support for some processors |
| |
Michael Opdenacker wrote: > > Also note that for the sake of convenience and consistency > between 32 and 64 bit, I move the declaration of force_mwait > from kernel/cpu/amd.c to kernel/setup_32.c > (force_mwait is already defined in kernel/setup_64.c). >
NAK NAK NAK NAK NAK NAK NAK
This is the totally wrong thing to do. The CPU initialization stuff should move *into* the CPU directory (unification based on the cleaned-up 32-bit code, not on the 64-bit code which is based on a fork of the pre-cleanup 32-bit code.)
-hpa
| |