Messages in this thread | | | Subject | Re: [PATCH linux-next] powerpc/powermac: Add missing of_node_put | From | Michael Ellerman <> | Date | Mon, 08 Dec 2008 10:58:18 +1100 |
| |
On Sun, 2008-12-07 at 16:43 +1100, Stephen Rothwell wrote: > Hi Paul, > > On Sun, 7 Dec 2008 13:31:00 +1100 Paul Mackerras <paulus@samba.org> wrote: > > > > I'm really in two minds about applying any of the of_node_put patches > > that only affect powermacs. The reference counts only matter on > > platforms where we update the OF device tree at runtime, which is > > currently only IBM pSeries machines. Since we don't have any hotplug > > on powermacs, and never will have, the OF device tree is completely > > static and we don't actually need refcounts on the nodes at all, so > > who cares if they're a bit higher than they might be? > > > > In particular, the VIA whose node we're looking for here is built-in > > on the motherboard, and there can never be more than one, and it can > > never be removed. > > I my mind it is about consistent use of the API and good examples for > people to copy. Also, in about a year you will be presented with the > same set of patches when a new pair of eyes looks at the same code and > notices the discrepancy ...
what-he-said++
Allowing the ref counting to be broken in one part of the code is just asking for it to be broken everywhere.
cheers
-- Michael Ellerman OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person [unhandled content-type:application/pgp-signature] | |