Messages in this thread | | | Date | Sat, 6 Dec 2008 11:14:59 +0530 | From | Balbir Singh <> | Subject | Re: [PATCH][UML] Boot broken due to buffer overrun |
| |
* Andrew Morton <akpm@linux-foundation.org> [2008-12-02 12:17:07]:
> On Sat, 29 Nov 2008 17:50:39 +0530 > Balbir Singh <balbir@linux.vnet.ibm.com> wrote: > > > * Pekka Enberg <penberg@cs.helsinki.fi> [2008-11-29 12:21:46]: > > > > > Hi Balbir, > > > > > > On Sat, Nov 29, 2008 at 12:08 PM, Balbir Singh > > > <balbir@linux.vnet.ibm.com> wrote: > > > > mconsole_init() passed 256 bytes as length in os_create_unix_socket, while > > > > the sizeof UNIX_PATH_MAX is 108. This patch fixes that problem and avoids > > > > a big overrun bug reported on UML bootup. > > > > > > Maybe mention that ->sun_path in struct sockaddr_un is UNIX_PATH_MAX > > > long which causes the problem? > > > > > > > Yes, the changelog can definitely add that to the changelog, I'll > > resend the patch if Jeff asks for it. > > Jeff's been quiet lately - I'll merge this one. >
Thanks!
> I also tagged it for -stable, subject to Jeff's OK. I'm wondering why > this wasn't observed in earlier kernels? >
I observed it with the newer toolchain that uses __USE_FORTIFY_LEVEL and __FORTIFY_SOURCE
-- Balbir
| |