Messages in this thread | | | Date | Wed, 31 Dec 2008 09:14:58 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH -tip] fix compilation error |
| |
* Frederic Weisbecker <fweisbec@gmail.com> wrote:
> On Tue, Dec 30, 2008 at 05:01:17PM -0800, H. Peter Anvin wrote: > > Frederic Weisbecker wrote: > > > On Tue, Dec 30, 2008 at 04:34:00PM -0800, H. Peter Anvin wrote: > > >> H. Peter Anvin wrote: > > >>> Applied to tip:tracing/kmemtrace2. > > >>> > > >> Hm, there still seems to be a build failure, in particular > > >> trace_output.h is missing. It looks to me at the moment as if just > > >> removing the #include works; assuming that compiles I will check that in > > >> to tip:tracing/kmemtrace2 as well. > > >> > > >> -hpa > > > > > > While I worked on this tracer, I had to base the thing against tracing/kmemtrace > > > because I needed the kmemtrace bits. > > > But I saw that this topic was a bit out of sync against tip/master, some updates from > > > Steven were not merged. But I didn't wonder, thinking that Ingo would resolve the > > > conflicts. But it seems there were some lost stuffs :-) > > > > > > I'm checking it and will send a patch to solve the rest... > > > > > > > If it's only the trace_output.h #include removal, don't worry about it; > > I'm about to commit that patch, but it would be good if you could check > > out the tracing/kmemtrace2 branch afterwards. > > > Yes this topic builds well after your patch. So it was just this header.
Could you check whether latest tip/master is still OK? I had these problems resolved locally (but forgot to push them out), and now i also had to do a few conflict resolutions with latest -git, hopefully i have not lost hpa's fixes ...
Ingo
| |