Messages in this thread | | | Date | Wed, 31 Dec 2008 17:33:41 +0200 | From | Boaz Harrosh <> | Subject | Re: [PATCH 1/9] exofs: osd Swiss army knife |
| |
Andrew Morton wrote: >> +int prepare_get_attr_list_add_entry(struct osd_request *req, >> + uint32_t page_num, >> + uint32_t attr_num, >> + uint32_t attr_len) >> +{ >> + struct osd_attr attr = { >> + .page = page_num, > > Kernel developers expect a field called "page" to have type `struct > page *'. osd_attr.page is thus designed to confuse. > >> ... >> >
Rant below (can be ignored): This single fix will cause a massive change to the open-osd initiator patchset, (18 patches), and resubmission .I made the mistake because this name originates from a file that all naming conventions are taken from the OSD standard text. However this is no excuse for using a well known Kernel construct name. I will fix it. And will be more careful in the future.
Thanks Boaz
| |