lkml.org 
[lkml]   [2008]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/1] ATA: piix, fix pointer deref on suspend
    Date
    Hi,

    I've found this issue in the mmotm 2008-12-02-17-08.

    --

    Commit
    ata_piix: add borked Tecra M4 to broken suspend list
    introduced DMI variables checking, but they can be null, so that
    we possibly dereference null.

    Check if they are null and avoid checks in that case.

    Solves:
    BUG: unable to handle kernel NULL pointer dereference at 0000000000000000
    IP: [<ffffffff8043da97>] piix_pci_device_suspend+0x117/0x230

    Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
    Cc: Jeff Garzik <jgarzik@redhat.com>
    Cc: Alexandru Romanescu <a_romanescu@yahoo.co.uk>
    Cc: Tejun Heo <tj@kernel.org>
    ---
    drivers/ata/ata_piix.c | 9 ++++++++-
    1 files changed, 8 insertions(+), 1 deletions(-)

    diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
    index d6d97d8..c11936e 100644
    --- a/drivers/ata/ata_piix.c
    +++ b/drivers/ata/ata_piix.c
    @@ -1072,7 +1072,14 @@ static int piix_broken_suspend(void)
    * matching is necessary because dmi_system_id.matches is
    * limited to four entries.
    */
    - if (!strcmp(dmi_get_system_info(DMI_SYS_VENDOR), "TOSHIBA") &&
    + if (dmi_get_system_info(DMI_SYS_VENDOR) &&
    + dmi_get_system_info(DMI_PRODUCT_NAME) &&
    + dmi_get_system_info(DMI_PRODUCT_VERSION) &&
    + dmi_get_system_info(DMI_PRODUCT_SERIAL) &&
    + dmi_get_system_info(DMI_BOARD_VENDOR) &&
    + dmi_get_system_info(DMI_BOARD_NAME) &&
    + dmi_get_system_info(DMI_BOARD_VERSION) &&
    + !strcmp(dmi_get_system_info(DMI_SYS_VENDOR), "TOSHIBA") &&
    !strcmp(dmi_get_system_info(DMI_PRODUCT_NAME), "000000") &&
    !strcmp(dmi_get_system_info(DMI_PRODUCT_VERSION), "000000") &&
    !strcmp(dmi_get_system_info(DMI_PRODUCT_SERIAL), "000000") &&
    --
    1.6.0.4


    \
     
     \ /
      Last update: 2008-12-03 09:17    [W:5.048 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site