Messages in this thread | | | From | Kumar Gala <> | Subject | Re: [PATCH][for 2.6.28] powerpc: Use physical cpu id when setting the processor affinity | Date | Tue, 2 Dec 2008 17:05:25 -0600 |
| |
On Dec 2, 2008, at 3:30 PM, Benjamin Herrenschmidt wrote:
> On Tue, 2008-12-02 at 13:37 -0600, Kumar Gala wrote: >> In the CONFIG_SMP case the irq_choose_cpu() code was returning back >> a logical cpu id not the physical id. We were writing that directly >> into the HW register. >> >> We need to be calling get_hard_smp_processor_id() so irq_choose_cpu() >> always returns a physical cpu id. > > That will probably do for now but if we ever move that routine to > generic code, I'd rather have the caller do the conversion.
Fair.. I felt at this point matching what the !CONFIG_SMP case of irq_choose_cpu() is doing was the best choice.
- k
| |