lkml.org 
[lkml]   [2008]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/3] cgroups: introduce link_css_set() to remove duplicate code
From
On Mon, Dec 1, 2008 at 7:18 PM, Li Zefan <lizf@cn.fujitsu.com> wrote:
>
> How about:
>
> /**
> * link_css_set - a helper function to link a css_set to a cgroup
> * @ tmp_cg_links: cg_cgroup_link objects allocated by allocate_cg_links()
> * @ cg: the css_set to be linked
> * @ cgrp: the destination cgroup
> */

Sounds good.

>
> Because we are linking all the css_sets to the root cgroup, so I think root_cgrp
> helps readability.
>

But we're creating the hierarchy at this point, so there can clearly
only be one cgroup any (which is the root cgroup).

I don't think it's any more or less readable, it just seems an
unnecessary change.

Paul


\
 
 \ /
  Last update: 2008-12-02 23:19    [W:0.076 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site