lkml.org 
[lkml]   [2008]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ext3: also fix loop in do_split()
Andrew Morton wrote:

> A local variable called `i' should always have signed type. In fact,
> it should have `int' type. Doing
>
> unsigned i;
>
> is an act of insane vandalism, punishable by spending five additional
> years coding in fortran.
>
> I suggest you fix this by giving `i' the type God intended, or by
> making it unsigned and then renaming it to something which is not
> intended to trick programmers and reviewers.
>
> Sheesh.

/me hangs head in shame, and points feebly but only halfheartedly at the
other people who reviewed the change when it originally went in... I
have no idea what I was thinking. Sorry. Please don't make me go back
to Fortran.

-Eric


\
 
 \ /
  Last update: 2008-12-02 21:39    [W:0.032 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site