lkml.org 
[lkml]   [2008]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/2] memcg: mem_cgroup->prev_priority protected by lock.
Date
> On Tue,  2 Dec 2008 16:11:07 +0900 (JST)
> KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
>
> >
> > Currently, mem_cgroup doesn't have own lock and almost its member doesn't need.
> > (e.g. info is protected by zone lock, stat is per cpu variable)
> >
> > However, there is one explict exception. mem_cgroup->prev_priorit need lock,
> > but doesn't protect.
> > Luckly, this is NOT bug because prev_priority isn't used for current reclaim code.
> >
> > However, we plan to use prev_priority future again.
> > Therefore, fixing is better.
> >
> >
> > In addision, we plan to reuse this lock for another member.
> > Then "misc_lock" name is better than "prev_priority_lock".
> >
> please use better name...reclaim_param_lock or some ?

good idea :)

Will fix.





\
 
 \ /
  Last update: 2008-12-02 08:23    [W:0.028 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site