Messages in this thread | | | From | KOSAKI Motohiro <> | Subject | Re: [PATCH 1/2] memcg: mem_cgroup->prev_priority protected by lock. | Date | Tue, 2 Dec 2008 16:19:20 +0900 (JST) |
| |
> On Tue, 2 Dec 2008 16:11:07 +0900 (JST) > KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote: > > > > > Currently, mem_cgroup doesn't have own lock and almost its member doesn't need. > > (e.g. info is protected by zone lock, stat is per cpu variable) > > > > However, there is one explict exception. mem_cgroup->prev_priorit need lock, > > but doesn't protect. > > Luckly, this is NOT bug because prev_priority isn't used for current reclaim code. > > > > However, we plan to use prev_priority future again. > > Therefore, fixing is better. > > > > > > In addision, we plan to reuse this lock for another member. > > Then "misc_lock" name is better than "prev_priority_lock". > > > please use better name...reclaim_param_lock or some ?
good idea :)
Will fix.
| |