Messages in this thread | | | Date | Tue, 2 Dec 2008 13:32:28 +0000 | From | Mark Brown <> | Subject | Re: [patch 2.6.28-rc7] regulator: catch some registration errors |
| |
On Mon, Dec 01, 2008 at 09:50:35PM -0800, David Brownell wrote:
> Prevent registration of duplicate "struct regulator" names. > They'd be unavailable, and clearly indicate something wrong.
This bit is good but...
> Also make sure the consumer device is provided. It's nonsensical > to omit these, and not a documented part of the interface. Since > no code in mainline does such stuff, this is just anti-oops medicine.
...we do still need to cater for cpufreq and other struct deviceless consumers. If you can guarantee that no such consumers will ever exist then great but we're not there yet.
| |