Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH 0/8] ide-cd: first conversion batch | Date | Fri, 19 Dec 2008 21:15:40 +0100 |
| |
Hi,
On Thursday 18 December 2008, Borislav Petkov wrote: > Hi Bart, > > here's the first batch of conversion patches. Now ide_issue_pc/ide_transfer_pc > are almost completely aligned to their ide-cd counterparts > cdrom_start_packet_command/cdrom_transfer_packet_command. The only thing
Looks good generally but I need more time for detailed review.
[ Your super-quick action on this has caught me unprepared. ;) ]
> missing is the setting of the irq handler through ide_set_handler but this > is not that trivial since if i'd moved ide-cd's irq handler to ide-atapi > that would suck in a bunch of other ide-cd functions which is not what we > want, (yes/no)? and I'm going to have to ponder a little bit more on that.
Yes, we don't want to move them over. In worst case we can add ide_handler_t *__old_pc_handler to ide_drive_t and set it in ide-cd (an acceptable hack this time) but there might be better options.
Thanks, Bart
| |