Messages in this thread | | | Date | Thu, 18 Dec 2008 22:06:28 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86: sigframe.h: add guard macro |
| |
* Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:
> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> > > Impact: cleanup > > Add missing guard macro _ASM_X86_SIGFRAME_H. > > Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> > --- > I forgot include guard:) > > arch/x86/include/asm/sigframe.h | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-)
applied, thanks!
It didnt matter in practice yet, because all uses of sigframe.h were single-instance and were done in flat .c files, not in .h files:
./arch/x86/kernel/asm-offsets_32.c:#include "sigframe.h" ./arch/x86/kernel/signal_32.c:#include "sigframe.h" ./arch/x86/kernel/signal_64.c:#include "sigframe.h" ./arch/x86/ia32/ia32_signal.c: struct _fpstate_ia32 fpstate_unused; /* look at kernel/sigframe.h */
but indeed it's better to have this fixed - just in case we put sigframe.h into an include file.
Ingo
| |