Messages in this thread | | | From | Jesse Barnes <> | Subject | Re: i82875p_edac: BAR 0 collision | Date | Tue, 16 Dec 2008 11:39:30 -0800 |
| |
On Sunday, November 23, 2008 12:44 pm Jarkko Lavinen wrote: > On Tue, Nov 11, 2008 at 12:01:52AM -0800, Andrew Morton wrote: > > Might be an EDAC driver regression. It might also be a consequence of > > PCI address space management fiddlings, but I think most of the changes > > there post-date 2.6.26? > > There were 3 issues: > 1, PCI resources of the hidden overflow device had to be added separately > 2. In nodule exit there is one more mci struct kobject put than > correspondig gets. > 3. The edac_mc waitqueue must be stopped before the polled memory > area disappears. > > Th attached patch fixes these problems. Module loads and removes now > without problems, with pci, edac, slab and kobject debug options > enabled. > > i82875p code looks so simlar to i82875p that is has likely the same > ref count issues as i82875p.
It's a little funky for a driver to be calling pci_bus_assign_resources; but if it really does act like a bus (sounds like this device does) it might be appropriate. I don't have any problems with the patch, but it's really up to Doug.
-- Jesse Barnes, Intel Open Source Technology Center
| |