lkml.org 
[lkml]   [2008]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH -v4 13/14] inotify: reimplement inotify using fsnotify
On Sat, Dec 13, 2008 at 11:44:01AM -0500, Eric Paris (eparis@redhat.com) wrote:
> > While you are at it, please update inode_setattr() so that it dropped
> > inotify watches if new permissions do not allow to read data.
>
> Now this isn't so easy.... Do you have suggestions how to do this with
> inotify as it stands today? the vfs needs to know what's hanging on the
> open fd in userspace... Not a bad idea. I'll look, but clearly not a
> core patch....

I could put inotify check into notify_change(), which will check if new
permissions do not allow reading for the users stored in
inode->inotify_watches, each one would be dereferenced to inotify
device, which holds a user context, which added watch object, so it can
be checked the same way generic_permission() works.

--
Evgeniy Polyakov


\
 
 \ /
  Last update: 2008-12-15 16:51    [W:0.050 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site